✨ 메인페이지 학교 목록에 중앙대 칩 추가 - #625
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Review limit reached
Next review available in: 44 seconds You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dea0391fac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| homeUniversityId: 3, | ||
| name: HomeUniversity.CHUNGANG, | ||
| slug: "chungang", |
There was a problem hiding this comment.
When a user selects the new 중앙대 option and follows either “더보기” or “학교 검색하기,” the generated URL starts with /university/chungang, but the reviewed apps/web/next.config.mjs still limits the catalog rewrites to (inha|kyunghee) at lines 24 and 114–119, and apps/web has no local catalog route to handle this path. Consequently, these links and the newly emitted Chungang sitemap URLs return 404 unless a separate configuration change is deployed first; add chungang to the rewrite and legacy-redirect pattern before exposing it through this shared list.
AGENTS.md reference: AGENTS.md:L99-L99
Useful? React with 👍 / 👎.
1 participant
요약
메인페이지 파견학교 목록의 홈 대학 필터 칩에 중앙대를 추가합니다.
apps/university-web에는 이미 중앙대가 등록되어 있었으나(#622),apps/web에는 빠져 있어 메인페이지 칩·sitemap에 노출되지 않았습니다.변경 내용
types/university.ts—HomeUniversityName에CHUNGANG = "중앙대학교",HomeUniversitySlug에"chungang"추가constants/university.ts—HOME_UNIVERSITY_SLUG_MAP/HOME_UNIVERSITY_TO_SLUG_MAP/HOME_UNIVERSITY_LIST/HOME_UNIVERSITY_SLUGS에 중앙대 추가 (homeUniversityId: 3)public/images/univs/chungang.png— 로고 추가 (apps/web에서 현재 렌더되지는 않지만logoUrl경로가 비지 않도록 university-web과 동일 파일 배치)칩 외에 함께 반영되는 것:
isMatchedHomeUniversityName이HomeUniversityNameenum으로 정규화하므로 API의중앙대학교응답과 매칭됩니다./university/chungangHOME_UNIVERSITY_LIST기반이라/university/chungang자동 포함maxChoiceCount 관련
HomeUniversityInfo의 필수 필드라 값이 필요했는데, 실제 값(인하대 3 / 경희대 5)은 관리자 API 인증이 필요해 확인하지 못했습니다.DEFAULT_MAX_CHOICE_COUNT(3)를 그대로 지정했고, 이는 현재 프로덕션 동작과 정확히 동일합니다. 지금도 중앙대는 목록에 없어getHomeUniversityById(3)가undefined를 반환하고 같은 상수로 폴백하기 때문입니다. 즉 이 PR은 지원 플로우 동작을 바꾸지 않습니다.실제 값이 3이 아니라면 별도 수정이 필요합니다. 코드에 TODO를 남겨두었습니다.
배포 의존성
"더보기" 링크(
/university/chungang)가 열리려면 #624(rewrite 슬러그 수정)가 먼저 머지·배포되어야 합니다. 현재apps/web의 rewrite 패턴이(inha|kyunghee)라 해당 경로가 404입니다. 칩 자체와 필터링은 이 PR만으로 동작합니다.두 PR 모두
apps/web변경이므로, 머지 후Promote Main to Release Branches를web타깃으로 한 번 실행하면 함께 반영됩니다.검증
pnpm --filter @solid-connect/web run lint:check— 통과pnpm --filter @solid-connect/web run typecheck— 통과pnpm --filter @solid-connect/web run build— 통과전체 | 인하대 | 경희대 | 중앙대,getHomeUniversityById(3)→ 중앙대학교 / slugchungang/ maxChoiceCount 3 (DEFAULT와 동일)🤖 Generated with Claude Code